This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Enabled VSS4 support for Seat Service, fixed integration tests and DevContainer #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
approved these changes
Nov 1, 2023
int0x27
force-pushed
the
feature/seatservice_vss4_support
branch
4 times, most recently
from
73847ca
to
80ebc71
Compare
- Using env variable VSS=3, VSS3 compliant seat position is forced. default: VSS=4 - Implemented getting metadata from sdv::databroker::v1::Broker, CollectorClient renamed to KuksaClient - Added support for int arrays in createDatapoint() - broker_feeder example rewritten to actually work - debug dumps enhanced (e.g. DBF_DEBUG=5 SEAT_DEBUG=5 will dump deserialized GRPC messages and statuses) - fixed several bugs caught from new debugs (e.g. Collector.UpdateDatapoints() returning OK with errors. - Improved databrokerfeeder disconnection detection (previously didn't reconnect unless a feed is pending) - Added some shared functions in sdv::utils namespace - Added DataBrokerFeeder.Ready() function to check if we can actually feed data to databroker (connected, datapoints registered) - dbf checks if required metadata is available and if some datapoints are missing, tries to register all of them - tried to address starvation in DBF process thread by busy feeding (broker feeder example) - Although updateDatapoint errors are Logged (e.g. wrong type), for the moment we ignore the error, because DBF will flood databroker with errors trying to resend all. Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- update-protobuf.sh fixed, also added "--force" argument to get proto files from kuksa.val master - test_val_seat.py updated to detect VSS3/4 mode by env. variable "USE_VSS3" - bumped databroker container version to 0.4.1 - fixed vscode tasks to work with recent databroker releases (tar.gz packed in a .zip) - removed KDB_OPT forcing VSS3.1 in integration
- some megalinter suggestions applied - fixed pip3 install usage Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- Added script for updating upstream kuksa proto files: `/tools/update-kuksa-proto.sh` - Removed "gen_proto" dummy package in integration tests (pytest needs custom path to work now) - Added Actuator target value support in `VDBHelper` - Added test for Actuator target set usecase in `test_val_seat.py` - Fixed `test_feeder.py` to use VSS4.0 compliant datapoints - Updated Tesla DBC from upstream, added DogMode signal - Updated `dbc2val` mapping (DogMode is optional as it will be missing in databroker by default) - Updated `feedercan` version to 0.4.1 - Fixed `it-config` for new `dbc2val` properties - Updated vscode scripts for feedercan, integration test, kukca client - Reduced devcontainer image layer size to allow push in ttl.sh Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
int0x27
force-pushed
the
feature/seatservice_vss4_support
branch
from
5cc2400
to
24f1dca
Compare
- Improved python3.9+ detection in run-feedercan.sh - Added comment about pinned cobertura-action revision in github actions Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
to speedup codespaces startup - added missing 'file' command for seat service scripts Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- python binary was missing and failed hvac testcase - added required 'file' package that was missing in devcontainer - removed `dbcfeeder=debug` from `it-config`, as it was too spammy - added `feedercan.imageVersion` to `prerequisite_settings.json` - used for container version, while `feedercan.version` is used for standalone (dapr) testing - added most of the packages installed from devcontainer Dockerfile to tools/Devcontainer to optimize codespace startup Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
int0x27
changed the title
|
You can test local / container integration tests in codespaces: https://github.com/codespaces/new/eclipse/kuksa.val.services/pull/103?resume=1
|
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- added `--pack` and `--help` arguments to seat_service/build_release.sh and seat_service/build_debug.sh - fixed readmes - fixed build-debug.sh to use proper toolchain Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
- applied formatting patches Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
Signed-off-by: Ivan Kirchev <Ivan.Kirchev@bosch.com>
SebastianSchildt
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSS 4.0 support in Seat Service
VSS=3forces VSS 3.0 compliant seat position. default:VSS=4sdv::databroker::v1::Broker,CollectorClientrenamed toKuksaClientcreateDatapoint()broker_feederexample rewritten to actually workDBF_DEBUG=5 SEAT_DEBUG=5will dump deserialized GRPC messages and statuses)Collector.UpdateDatapoints()returning OK with errors.sdv::utilsnamespaceDataBrokerFeeder.Ready()function to check if we can actually feed data to databroker (connected, datapoints registered)updateDatapointerrors are Logged (e.g. wrong type), for the moment we ignore the error, because DBF will flood databroker with errors trying to resend all.General changes
./tools/update-kuksa-proto.shhvac_serviceproto files regenerated from upstream proto filesIntegration test changes for VSS 4.0
integration_test/update-protobuf.shfixed and proto files updated from upstreamtest_val_seat.pyupdated to detect VSS3/4 mode by env. variableUSE_VSS3databrokercontainer version to 0.4.1feedercanversion to 0.4.1tar.gzpacked in a.zip)KDB_OPTforcing VSS3.1 in integrationgen_protodummy package in integration tests (pytestneeds custom path to work now)VDBHelpertest_val_seat.pytest_feeder.pyto use VSS4.0 compliant datapointsDogModesignaldbc2valmapping (DogModeis optional as it will be missing in databroker by default)it-configfor newdbc2valproperties